Source/modules/navigatorconnect/ServicePortCollection.idl - Issue 1192913003: Start implementing new navigator.connect API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/navigatorconnect/ServicePortCollection.idl

Issue 1192913003: Start implementing new navigator.connect API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/navigatorconnect/ServicePortCollection.cpp ('K') | « Source/modules/navigatorconnect/ServicePortCollection.cpp ('k') | Source/modules/navigatorconnect/ServicePortConnectOptions.idl » ('j') | Source/modules/navigatorconnect/WorkerNavigatorServices.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://mkruisselbrink.github.io/navigator-connect/#idl-def-ServicePortCollec tion

	6 [

	7 Exposed=(Window,Worker),

	8 RuntimeEnabled=NavigatorConnect,

	9 ] interface ServicePortCollection : EventTarget {

	10 [CallWith=ScriptState] Promise<ServicePort> connect(DOMString url, optional ServicePortConnectOptions options);

	11 [CallWith=ScriptState] Promise<ServicePort> match(ServicePortMatchOptions op tions);

	12 [CallWith=ScriptState] Promise<sequence<ServicePort>> matchAll(optional Serv icePortMatchOptions options);

	13 attribute EventHandler onconnect;
	scheib 2015/06/23 03:57:21 Spec has a "Exposed=ServiceWorker" before the Even Spec has a "Exposed=ServiceWorker" before the EventHandlers (with indentation I don't understand. Just checking that nothing needs to be entered here? Perhaps a comment for why they differ. Marijn Kruisselbrink 2015/06/23 04:11:05 Oh yes, will definitely add a comment. I don't und Show quoted text On 2015/06/23 03:57:21, scheib wrote: > Spec has a "Exposed=ServiceWorker" before the EventHandlers (with indentation I > don't understand. Just checking that nothing needs to be entered here? Perhaps a > comment for why they differ. Oh yes, will definitely add a comment. I don't understand the indendation in the spec either, but it's currently missing here because the blink bindings removed support for per-attribute Exposed extended attributes a couple of days ago.
	14 attribute EventHandler onmessage;

	15 attribute EventHandler onclose;

	16 };

OLD	NEW