Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3225)

Unified Diff: build/android/pylib/base/base_test_sharder.py

Issue 11929038: [Android] Fix the reference to timed_out in BaseTestSharder retry logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base/base_test_sharder.py
diff --git a/build/android/pylib/base/base_test_sharder.py b/build/android/pylib/base/base_test_sharder.py
index 73621010f055b115537417409c201347d251e36d..e33ff87f9762a0c720f694386e78e8dfa9cddec5 100644
--- a/build/android/pylib/base/base_test_sharder.py
+++ b/build/android/pylib/base/base_test_sharder.py
@@ -127,6 +127,10 @@ class BaseTestSharder(object):
retry_devices -= TestResults.DeviceExceptions(results_lists)
# Retry on devices that didn't have any exception.
self.attached_devices = list(retry_devices)
+
+ # TODO(frankf): Fix the retry logic:
+ # - GetAllBroken() should report all tests not ran.
+ # - Do not break TestResults encapsulation.
if (retry == self.retries - 1 or
len(self.attached_devices) == 0):
all_passed = final_results.ok + test_results.ok
@@ -135,9 +139,11 @@ class BaseTestSharder(object):
break
else:
final_results.ok += test_results.ok
- # Timed out tests are not reported in GetAllBroken().
- if test_results.timed_out:
- final_results.timed_out = True
+ final_results.overall_timed_out = (final_results.overall_timed_out or
+ test_results.overall_timed_out)
+ final_results.overall_fail = (final_results.overall_fail or
+ test_results.overall_fail)
+
self.tests = []
for t in test_results.GetAllBroken():
self.tests += [t.name]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698