Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1192843005: Adjust TestExpectations for crrev.com/1198523002 (Closed)

Created:
5 years, 6 months ago by caitp (gmail)
Modified:
5 years, 6 months ago
Reviewers:
jsbell
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adjust TestExpectations for crrev.com/1198523002 v8 will be changing the error thrown when trying to make a cyclic prototype chain from generic `Error` to the ES6-specified `TypeError`. Once that lands the -expected.txt files for these tests should be updated. BUG=502427, v8:4197 R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
caitp (gmail)
PTAL --- need this until v8 roll
5 years, 6 months ago (2015-06-19 21:38:51 UTC) #1
jsbell
lgtm
5 years, 6 months ago (2015-06-19 22:10:17 UTC) #3
jsbell
5 years, 6 months ago (2015-06-19 22:13:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 197501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698