Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(84)

Issue 1192813002: DevTools: do no throw exception in "add watch" context menu item (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: do no throw exception in "add watch" context menu item BUG=502207 TBR=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lushnikov
4 years, 10 months ago (2015-06-19 12:16:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192813002/1
4 years, 10 months ago (2015-06-19 12:16:30 UTC) #3
pfeldman
lgtm
4 years, 10 months ago (2015-06-19 14:52:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67447)
4 years, 10 months ago (2015-06-19 15:27:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192813002/1
4 years, 10 months ago (2015-06-19 15:36:40 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 18:10:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197490

Powered by Google App Engine
This is Rietveld 408576698