Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp - Issue 1192803003: Fixing blink gc dump provider to have thread id in path for single process mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

Issue 1192803003: Fixing blink gc dump provider to have thread id in path for single process mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing build Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

diff --git a/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp b/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

index 0b4bd2ce7a0e9c8251d51e29d5cca7fe6509814b..434c366c42c4d8064dea193a1d2f1909f4736c0e 100644

--- a/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

+++ b/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp

@@ -7,6 +7,7 @@

#include "public/platform/Platform.h"

#include "public/platform/WebProcessMemoryDump.h"

+#include "wtf/Threading.h"

#include <gtest/gtest.h>

@@ -17,8 +18,8 @@ TEST(BlinkGCDumpProviderTest, MemoryDump)

WebProcessMemoryDump* dump = Platform::current()->createProcessMemoryDump();

ASSERT(dump);

BlinkGCMemoryDumpProvider::instance()->onMemoryDump(dump);

- ASSERT(dump->getMemoryAllocatorDump("blink_gc"));

- ASSERT(dump->getMemoryAllocatorDump("blink_gc/allocated_objects"));

+ ASSERT(dump->getMemoryAllocatorDump(String::format("blink_gc/thread_%lu", static_cast<unsigned long>(WTF::currentThread()))));

+ ASSERT(dump->getMemoryAllocatorDump(String::format("blink_gc/thread_%lu/allocated_objects", static_cast<unsigned long>(WTF::currentThread()))));

}

} // namespace blink

« no previous file with comments | « Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | no next file » | no next file with comments »