Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1192803003: Fixing blink gc dump provider to have thread id in path for single process mode. (Closed)

Created:
4 years, 10 months ago by ssid
Modified:
4 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixing blink gc dump provider to have thread id in path for single process mode. There can be multiple blink platform impl in the same process when run using single process mode or when the renderer has workers with blink. So, the path of the blink GC memory dumps is appended with thread id. Also, the total size of allocated objects is fixed to correct value. BUG=490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197531

Patch Set 1 #

Patch Set 2 : Fixing unittest. #

Patch Set 3 : Fixing build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ssid
Small change, PTAL.
4 years, 10 months ago (2015-06-19 11:52:54 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-19 12:09:28 UTC) #3
Primiano Tucci (use gerrit)
lgtm
4 years, 10 months ago (2015-06-19 12:42:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192803003/40001
4 years, 10 months ago (2015-06-20 13:09:04 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-20 15:21:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197531

Powered by Google App Engine
This is Rietveld 408576698