Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1192773004: Teach Sky buttons and dialogs how to use the new Theme system (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach Sky buttons and dialogs how to use the new Theme system R=eseidel@chromium.org, eseidel Committed: https://chromium.googlesource.com/external/mojo/+/eb1e5489bf94c298d7f8c9e4645b746383543bfe

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix reference to unused thing #

Patch Set 4 : Material design dialogs are white; update test results #

Patch Set 5 : abarth cr feedback and add missing import #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -48 lines) Patch
M sky/sdk/lib/theme/theme_data.dart View 1 chunk +12 lines, -14 lines 0 comments Download
M sky/sdk/lib/widgets/dialog.dart View 3 chunks +12 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/flat_button.dart View 1 2 3 4 1 chunk +6 lines, -9 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 3 chunks +13 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/material_button.dart View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 2 chunks +12 lines, -15 lines 0 comments Download
M sky/sdk/lib/widgets/theme.dart View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M sky/tests/widgets/dialog-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jackson
5 years, 6 months ago (2015-06-23 00:49:52 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-23 00:50:59 UTC) #2
jackson
5 years, 6 months ago (2015-06-23 17:13:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
eb1e5489bf94c298d7f8c9e4645b746383543bfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698