Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 1192773002: Ignore builders without result (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 Google Inc. All rights reserved. 1 # Copyright (c) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 # not overriding execute() - pylint: disable=W0223 316 # not overriding execute() - pylint: disable=W0223
317 317
318 def __init__(self, options=None): 318 def __init__(self, options=None):
319 super(AbstractParallelRebaselineCommand, self).__init__(options=options) 319 super(AbstractParallelRebaselineCommand, self).__init__(options=options)
320 self._builder_data = {} 320 self._builder_data = {}
321 321
322 def builder_data(self): 322 def builder_data(self):
323 if not self._builder_data: 323 if not self._builder_data:
324 for builder_name in self._release_builders(): 324 for builder_name in self._release_builders():
325 builder = self._tool.buildbot.builder_with_name(builder_name) 325 builder = self._tool.buildbot.builder_with_name(builder_name)
326 self._builder_data[builder_name] = builder.latest_layout_test_re sults() 326 builder_results = builder.latest_layout_test_results()
327 if builder_results:
328 self._builder_data[builder_name] = builder_results
329 else:
330 _log.warning("No result for builder '%s'" % builder_name)
327 return self._builder_data 331 return self._builder_data
328 332
329 # The release builders cycle much faster than the debug ones and cover all t he platforms. 333 # The release builders cycle much faster than the debug ones and cover all t he platforms.
330 def _release_builders(self): 334 def _release_builders(self):
331 release_builders = [] 335 release_builders = []
332 for builder_name in builders.all_builder_names(): 336 for builder_name in builders.all_builder_names():
333 if builder_name.find('ASAN') != -1: 337 if builder_name.find('ASAN') != -1:
334 continue 338 continue
335 port = self._tool.port_factory.get_from_builder_name(builder_name) 339 port = self._tool.port_factory.get_from_builder_name(builder_name)
336 if port.test_configuration().build_type == 'release': 340 if port.test_configuration().build_type == 'release':
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
945 self._tool.scm().checkout_branch(old_branch_name) 949 self._tool.scm().checkout_branch(old_branch_name)
946 else: 950 else:
947 self._log_queue.put(self.QUIT_LOG) 951 self._log_queue.put(self.QUIT_LOG)
948 log_thread.join() 952 log_thread.join()
949 953
950 def execute(self, options, args, tool): 954 def execute(self, options, args, tool):
951 self._verbose = options.verbose 955 self._verbose = options.verbose
952 while True: 956 while True:
953 self._do_one_rebaseline() 957 self._do_one_rebaseline()
954 time.sleep(self.SLEEP_TIME_IN_SECONDS) 958 time.sleep(self.SLEEP_TIME_IN_SECONDS)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698