Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/renderer/utils_native_handler.cc

Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/v8_context_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/utils_native_handler.cc
diff --git a/extensions/renderer/utils_native_handler.cc b/extensions/renderer/utils_native_handler.cc
index 209069cb942d3fd74b96a63c0351b3835d5087d7..49ff32ad7eae12bd2f0c5a80017d935681a6c443 100644
--- a/extensions/renderer/utils_native_handler.cc
+++ b/extensions/renderer/utils_native_handler.cc
@@ -62,6 +62,7 @@ void UtilsNativeHandler::CreateClassWrapper(
// TODO(fsamuel): Move privates from ModuleSystem to a shared location.
v8::Local<v8::Object> natives(context()->module_system()->NewInstance());
CHECK(!natives.IsEmpty()); // this can happen if v8 has issues
+
v8::Local<v8::Function> func = func_as_value.As<v8::Function>();
v8::Local<v8::Value> func_args[] = {
context()->safe_builtins()->GetObjekt(),
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/v8_context_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698