extensions/renderer/object_backed_native_handler.h - Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/object_backed_native_handler.h

Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/object_backed_native_handler.h

diff --git a/extensions/renderer/object_backed_native_handler.h b/extensions/renderer/object_backed_native_handler.h

index e4e13a539608281f6e3a0a9403e6f810005b5f7b..dbddbbf2e0b4c607c983d6711720f741a3b9c5f0 100644

--- a/extensions/renderer/object_backed_native_handler.h

+++ b/extensions/renderer/object_backed_native_handler.h

@@ -27,7 +27,7 @@ class ObjectBackedNativeHandler : public NativeHandler {

// Create an object with bindings to the native functions defined through

// RouteFunction().

- v8::Local<v8::Object> NewInstance() override;

+ v8::MaybeLocal<v8::Object> NewInstance() override;

v8::Isolate* GetIsolate() const;