Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: extensions/renderer/module_system_unittest.cc

Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/module_system_unittest.cc
diff --git a/extensions/renderer/module_system_unittest.cc b/extensions/renderer/module_system_unittest.cc
index c5c916eb103f0c4e6ecf7d528441b425bad8303a..c099262a8374352f7bcf8105948fdf9e592e525a 100644
--- a/extensions/renderer/module_system_unittest.cc
+++ b/extensions/renderer/module_system_unittest.cc
@@ -408,11 +408,11 @@ TEST_F(ModuleSystemTest, TestRequireAsyncFromAnotherContext) {
gin::ModuleRegistry::From(env()->context()->v8_context())
->AddBuiltinModule(
env()->isolate(), "natives",
- other_env->module_system()->NewInstance());
+ other_env->module_system()->NewInstance().ToLocalChecked());
gin::ModuleRegistry::From(other_env->context()->v8_context())
->AddBuiltinModule(
env()->isolate(), "natives",
- env()->module_system()->NewInstance());
+ env()->module_system()->NewInstance().ToLocalChecked());
env()->module_system()->Require("test");
RunResolvedPromises();
}
@@ -445,11 +445,11 @@ TEST_F(ModuleSystemTest, TestRequireAsyncBetweenContexts) {
gin::ModuleRegistry::From(env()->context()->v8_context())
->AddBuiltinModule(
env()->isolate(), "natives",
- other_env->module_system()->NewInstance());
+ other_env->module_system()->NewInstance().ToLocalChecked());
gin::ModuleRegistry::From(other_env->context()->v8_context())
->AddBuiltinModule(
env()->isolate(), "natives",
- env()->module_system()->NewInstance());
+ env()->module_system()->NewInstance().ToLocalChecked());
env()->module_system()->Require("test");
RunResolvedPromises();
}
@@ -471,7 +471,7 @@ TEST_F(ModuleSystemTest, TestRequireAsyncFromContextWithNoModuleRegistry) {
gin::ModuleRegistry::From(env()->context()->v8_context())
->AddBuiltinModule(
env()->isolate(), "natives",
- other_env->module_system()->NewInstance());
+ other_env->module_system()->NewInstance().ToLocalChecked());
other_env->ShutdownGin();
env()->module_system()->Require("test");
RunResolvedPromises();
@@ -489,7 +489,7 @@ TEST_F(ModuleSystemTest, TestRequireAsyncFromContextWithNoModuleSystem) {
gin::ModuleRegistry::From(env()->context()->v8_context())
->AddBuiltinModule(
env()->isolate(), "natives",
- other_env->module_system()->NewInstance());
+ other_env->module_system()->NewInstance().ToLocalChecked());
other_env->ShutdownModuleSystem();
env()->module_system()->Require("test");
RunResolvedPromises();

Powered by Google App Engine
This is Rietveld 408576698