core/src/fxge/ge/fx_ge_fontmap.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/ge/fx_ge_fontmap.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/ge/fx_ge_fontmap.cpp

diff --git a/core/src/fxge/ge/fx_ge_fontmap.cpp b/core/src/fxge/ge/fx_ge_fontmap.cpp

index 8406b3c37bb55e50d2843d8dd1dfdaf66064acb6..8956cd1c886ec4d9e42360a5b4a6a6c67362774d 100644

--- a/core/src/fxge/ge/fx_ge_fontmap.cpp

+++ b/core/src/fxge/ge/fx_ge_fontmap.cpp

@@ -71,9 +71,7 @@ CFX_FontMgr::CFX_FontMgr()

}

CFX_FontMgr::~CFX_FontMgr()

{

- if (m_pBuiltinMapper) {

- delete m_pBuiltinMapper;

- }

+ delete m_pBuiltinMapper;

FreeCache();

if (m_FTLibrary) {

FXFT_Done_FreeType(m_FTLibrary);

« no previous file with comments | « core/src/fxge/ge/fx_ge_font.cpp ('k') | core/src/fxge/ge/fx_ge_text.cpp » ('j') | no next file with comments »