core/src/fxcodec/jbig2/JBig2_PatternDict.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/jbig2/JBig2_PatternDict.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/jbig2/JBig2_PatternDict.cpp

diff --git a/core/src/fxcodec/jbig2/JBig2_PatternDict.cpp b/core/src/fxcodec/jbig2/JBig2_PatternDict.cpp

index 0c6e5be8ce98ea6199606a20a2b3fdbfa0197d4d..df45288812207bf90ce9d3bdcf8206049a8e010c 100644

--- a/core/src/fxcodec/jbig2/JBig2_PatternDict.cpp

+++ b/core/src/fxcodec/jbig2/JBig2_PatternDict.cpp

@@ -15,9 +15,7 @@ CJBig2_PatternDict::~CJBig2_PatternDict()

{

if(HDPATS) {

for(FX_DWORD i = 0; i < NUMPATS; i++) {

- if(HDPATS[i]) {

- delete HDPATS[i];

- }

+ delete HDPATS[i];

}

m_pModule->JBig2_Free(HDPATS);

}