core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp

index 1146d76695dd7476250fbc2d39a71f0f617b9027..0ee7a0da7d0d8b3f9de19d723f14e6d7e8162756 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp

@@ -930,9 +930,7 @@ CPDF_SeparationCS::~CPDF_SeparationCS()

if (m_pAltCS) {

m_pAltCS->ReleaseCS();

}

- if (m_pFunc) {

- delete m_pFunc;

- }

+ delete m_pFunc;

}

void CPDF_SeparationCS::GetDefaultValue(int iComponent, FX_FLOAT& value, FX_FLOAT& min, FX_FLOAT& max) const

{

@@ -1020,9 +1018,7 @@ public:

};

CPDF_DeviceNCS::~CPDF_DeviceNCS()

{

- if (m_pFunc) {

- delete m_pFunc;

- }

+ delete m_pFunc;

if (m_pAltCS) {

m_pAltCS->ReleaseCS();

}