core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

index 784fc0169ec5365739ef3c1e4d4e034454e37f8b..2db8d6095f9399ca838091cd4e1e20a4cea5746e 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

@@ -1044,9 +1044,7 @@ CPDF_Font* CPDF_Document::AddFont(CFX_Font* pFont, int charset, FX_BOOL bVert)

}

- if (pEncoding) {

- delete pEncoding;

- }

+ delete pEncoding;

pFontDesc->SetAtInteger("StemV", nStemV);

AddIndirectObject(pFontDesc);

pFontDict->SetAtReference("FontDescriptor", this, pFontDesc);