core/src/fxge/apple/fx_quartz_device.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/apple/fx_quartz_device.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/apple/fx_quartz_device.cpp

diff --git a/core/src/fxge/apple/fx_quartz_device.cpp b/core/src/fxge/apple/fx_quartz_device.cpp

index 8f0f4db6ba6f91b94ee7870121982f5cbfc81722..d1e4f544ba85f3a4da9db18d7a6280b2a5ed0951 100644

--- a/core/src/fxge/apple/fx_quartz_device.cpp

+++ b/core/src/fxge/apple/fx_quartz_device.cpp

@@ -1082,7 +1082,7 @@ CFX_QuartzDevice::~CFX_QuartzDevice()

if (m_pContext) {

CGContextRelease(m_pContext);

}

- if (GetBitmap() && m_bOwnedBitmap) {

+ if (m_bOwnedBitmap) {

delete GetBitmap();

}