core/src/fxge/android/fpf_skiafontmgr.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/android/fpf_skiafontmgr.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/android/fpf_skiafontmgr.cpp

diff --git a/core/src/fxge/android/fpf_skiafontmgr.cpp b/core/src/fxge/android/fpf_skiafontmgr.cpp

index ec7af81e79d2b57435a54d75539b1518b4c50507..86bb052435df5059cb71b614da6ae4148f369481 100644

--- a/core/src/fxge/android/fpf_skiafontmgr.cpp

+++ b/core/src/fxge/android/fpf_skiafontmgr.cpp

@@ -245,9 +245,7 @@ CFPF_SkiaFontMgr::~CFPF_SkiaFontMgr()

m_FamilyFonts.RemoveAll();

for (int32_t i = m_FontFaces.GetUpperBound(); i >= 0; i--) {

CFPF_SkiaFontDescriptor *pFont = (CFPF_SkiaFontDescriptor*)m_FontFaces.ElementAt(i);

- if (pFont) {

- delete pFont;

- }

+ delete pFont;

}

m_FontFaces.RemoveAll();

if (m_FTLibrary) {