core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

index 5748e23efe069350beafbee07be84ce3bf800f5c..3ee2222d8bfc3d3a62e59c8161e66ed55eb0c832 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

@@ -994,9 +994,7 @@ void CPDF_RenderStatus::DrawTilingPattern(CPDF_TilingPattern* pPattern, CPDF_Pag

m_pDevice->RestoreState();

}

m_pDevice->RestoreState();

- if (pStates) {

- delete pStates;

- }

+ delete pStates;

return;

}

if (bAligned) {