Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: fpdfsdk/src/javascript/app.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/fxedit/fxet_edit.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_ListBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../include/javascript/JavaScript.h" 7 #include "../../include/javascript/JavaScript.h"
8 #include "../../include/javascript/IJavaScript.h" 8 #include "../../include/javascript/IJavaScript.h"
9 #include "../../include/javascript/JS_Define.h" 9 #include "../../include/javascript/JS_Define.h"
10 #include "../../include/javascript/JS_Object.h" 10 #include "../../include/javascript/JS_Object.h"
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 // pValue = new CJS_Value[iLenth]; 353 // pValue = new CJS_Value[iLenth];
354 354
355 for(int i = 0; i < iLenth; i++) 355 for(int i = 0; i < iLenth; i++)
356 { 356 {
357 carray.GetElement(i, *pValue); 357 carray.GetElement(i, *pValue);
358 swMsg += (*pValue).ToCFXWideStri ng(); 358 swMsg += (*pValue).ToCFXWideStri ng();
359 if (i < iLenth - 1) 359 if (i < iLenth - 1)
360 swMsg += L", "; 360 swMsg += L", ";
361 } 361 }
362 362
363 » » » » » if(pValue) delete pValue; 363 delete pValue;
364 } 364 }
365 } 365 }
366 366
367 if (swTitle == L"") 367 if (swTitle == L"")
368 swTitle = JSGetStringFromID((CJS_Context*)cc, ID S_STRING_JSALERT); 368 swTitle = JSGetStringFromID((CJS_Context*)cc, ID S_STRING_JSALERT);
369 } 369 }
370 else if (params[0].GetType() == VT_boolean) 370 else if (params[0].GetType() == VT_boolean)
371 { 371 {
372 FX_BOOL bGet = params[0].ToBool(); 372 FX_BOOL bGet = params[0].ToBool();
373 if (bGet) 373 if (bGet)
(...skipping 544 matching lines...) Expand 10 before | Expand all | Expand 10 after
918 918
919 FX_BOOL app::media(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError) 919 FX_BOOL app::media(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
920 { 920 {
921 return FALSE; 921 return FALSE;
922 } 922 }
923 923
924 FX_BOOL app::execDialog(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Val ue& vRet, CFX_WideString& sError) 924 FX_BOOL app::execDialog(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Val ue& vRet, CFX_WideString& sError)
925 { 925 {
926 return TRUE; 926 return TRUE;
927 } 927 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/fxedit/fxet_edit.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_ListBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698