Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: core/src/fxge/android/fpf_skiamodule.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/src/fxge/android/fpf_skiafontmgr.cpp ('k') | core/src/fxge/apple/apple_int.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fx_fpf.h" 7 #include "fx_fpf.h"
8 #if _FX_OS_ == _FX_ANDROID_ 8 #if _FX_OS_ == _FX_ANDROID_
9 #include "fpf_skiamodule.h" 9 #include "fpf_skiamodule.h"
10 #include "fpf_skiafontmgr.h" 10 #include "fpf_skiafontmgr.h"
11 static IFPF_DeviceModule *gs_pPFModule = NULL; 11 static IFPF_DeviceModule *gs_pPFModule = NULL;
12 IFPF_DeviceModule* FPF_GetDeviceModule() 12 IFPF_DeviceModule* FPF_GetDeviceModule()
13 { 13 {
14 if (!gs_pPFModule) { 14 if (!gs_pPFModule) {
15 gs_pPFModule = new CFPF_SkiaDeviceModule; 15 gs_pPFModule = new CFPF_SkiaDeviceModule;
16 } 16 }
17 return gs_pPFModule; 17 return gs_pPFModule;
18 } 18 }
19 CFPF_SkiaDeviceModule::~CFPF_SkiaDeviceModule() 19 CFPF_SkiaDeviceModule::~CFPF_SkiaDeviceModule()
20 { 20 {
21 if (m_pFontMgr) { 21 delete m_pFontMgr;
22 delete m_pFontMgr;
23 }
24 } 22 }
25 void CFPF_SkiaDeviceModule::Destroy() 23 void CFPF_SkiaDeviceModule::Destroy()
26 { 24 {
27 if (gs_pPFModule) { 25 if (gs_pPFModule) {
28 delete (CFPF_SkiaDeviceModule*)gs_pPFModule; 26 delete (CFPF_SkiaDeviceModule*)gs_pPFModule;
29 gs_pPFModule = NULL; 27 gs_pPFModule = NULL;
30 } 28 }
31 } 29 }
32 IFPF_FontMgr* CFPF_SkiaDeviceModule::GetFontMgr() 30 IFPF_FontMgr* CFPF_SkiaDeviceModule::GetFontMgr()
33 { 31 {
34 if (!m_pFontMgr) { 32 if (!m_pFontMgr) {
35 m_pFontMgr = new CFPF_SkiaFontMgr; 33 m_pFontMgr = new CFPF_SkiaFontMgr;
36 if (!m_pFontMgr->InitFTLibrary()) { 34 if (!m_pFontMgr->InitFTLibrary()) {
37 delete m_pFontMgr; 35 delete m_pFontMgr;
38 return NULL; 36 return NULL;
39 } 37 }
40 } 38 }
41 return (IFPF_FontMgr*)m_pFontMgr; 39 return (IFPF_FontMgr*)m_pFontMgr;
42 } 40 }
43 #endif 41 #endif
OLDNEW
« no previous file with comments | « core/src/fxge/android/fpf_skiafontmgr.cpp ('k') | core/src/fxge/apple/apple_int.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698