Cleanup: Do not check pointers before deleting them.

core/src/fpdfapi/fpdf_page/fpdf_page.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "pageint.h"
 CPDF_PageObject* CPDF_PageObject::Create(int type)
@@ skipping 679 matching lines @@
         return;
     }
     CFX_FloatRect rect = m_ClipPath.GetClipBox();
     m_Left = rect.left;
     m_Bottom = rect.bottom;
     m_Right = rect.right;
     m_Top = rect.top;
 }
 CPDF_FormObject::~CPDF_FormObject()
 {
-    if (m_pForm) {
-        delete m_pForm;
-    }
+    delete m_pForm;
 }
 void CPDF_FormObject::Transform(const CFX_AffineMatrix& matrix)
 {
     m_FormMatrix.Concat(matrix);
     CalcBoundingBox();
 }
 void CPDF_FormObject::CopyData(const CPDF_PageObject* pSrc)
 {
     const CPDF_FormObject* pSrcObj = (const CPDF_FormObject*)pSrc;
-    if (m_pForm) {
-        delete m_pForm;
-    }
+    delete m_pForm;
     m_pForm = pSrcObj->m_pForm->Clone();
     m_FormMatrix = pSrcObj->m_FormMatrix;
 }
 void CPDF_FormObject::CalcBoundingBox()
 {
     CFX_FloatRect form_rect = m_pForm->CalcBoundingBox();
     form_rect.Transform(&m_FormMatrix);
     m_Left = form_rect.left;
     m_Bottom = form_rect.bottom;
     m_Right = form_rect.right;
     m_Top = form_rect.top;
 }
 CPDF_PageObjects::CPDF_PageObjects(FX_BOOL bReleaseMembers) : m_ObjectList(128)
 {
     m_bBackgroundAlphaNeeded = FALSE;
     m_bReleaseMembers = bReleaseMembers;
     m_ParseState = PDF_CONTENT_NOT_PARSED;
     m_pParser = NULL;
     m_pFormStream = NULL;
     m_pResources = NULL;
 }
 CPDF_PageObjects::~CPDF_PageObjects()
 {
-    if (m_pParser) {
-        delete m_pParser;
-    }
+    delete m_pParser;
     if (!m_bReleaseMembers) {
         return;
     }
     FX_POSITION pos = m_ObjectList.GetHeadPosition();
     while (pos) {
         delete (CPDF_PageObject*)m_ObjectList.GetNext(pos);
     }
 }
 void CPDF_PageObjects::ContinueParse(IFX_Pause* pPause)
 {
@@ skipping 93 matching lines @@
     if (pGroup->GetInteger(FX_BSTRC("I"))) {
         m_Transparency |= PDFTRANS_ISOLATED;
     }
     if (pGroup->GetInteger(FX_BSTRC("K"))) {
         m_Transparency |= PDFTRANS_KNOCKOUT;
     }
 }
 void CPDF_PageObjects::ClearCacheObjects()
 {
     m_ParseState = PDF_CONTENT_NOT_PARSED;
-    if (m_pParser) {
-        delete m_pParser;
-    }
+    delete m_pParser;
     m_pParser = NULL;
     if (m_bReleaseMembers) {
         FX_POSITION pos = m_ObjectList.GetHeadPosition();
         while (pos) {
             delete (CPDF_PageObject*)m_ObjectList.GetNext(pos);
         }
     }
     m_ObjectList.RemoveAll();
 }
 CPDF_Page::CPDF_Page()
@@ skipping 210 matching lines @@
     matrix = m_PageMatrix;
     matrix.Concat(display_matrix);
 }
 CPDF_ParseOptions::CPDF_ParseOptions()
 {
     m_bTextOnly = FALSE;
     m_bMarkedContent = TRUE;
     m_bSeparateForm = TRUE;
     m_bDecodeInlineImage = FALSE;
 }