Cleanup: Do not check pointers before deleting them.

core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxcrt/fx_ext.h"
 #include "../../../include/fpdfapi/fpdf_serial.h"
 #include "editint.h"
 
@@ skipping 1949 matching lines @@
         return -1;
     }
     if (m_File.AppendString(FX_BSTRC("\r\n%%EOF\r\n")) < 0) {
         return -1;
     }
     m_File.Flush();
     return m_iStage = 100;
 }
 void CPDF_Creator::Clear()
 {
-    if (m_pXRefStream) {
-        delete m_pXRefStream;
-        m_pXRefStream = NULL;
-    }
+    delete m_pXRefStream;
+    m_pXRefStream = NULL;
     m_File.Clear();
     m_NewObjNumArray.RemoveAll();
     if (m_pIDArray) {
         m_pIDArray->Release();
         m_pIDArray = NULL;
     }
 }
 FX_BOOL CPDF_Creator::Create(const FX_CHAR* filename, FX_DWORD flags)
 {
     if (!m_File.AttachFile(filename)) {
@@ skipping 77 matching lines @@
         FX_Free(pBuffer);
         return;
     }
     m_pIDArray->Add(m_pIDArray->GetElement(0)->Clone());
     if (m_pEncryptDict && !pOldIDArray && m_pParser && bNewId) {
         if (m_pEncryptDict->GetString(FX_BSTRC("Filter")) == FX_BSTRC("Standard")) {
             CPDF_StandardSecurityHandler handler;
             CFX_ByteString user_pass = m_pParser->GetPassword();
             FX_DWORD flag = PDF_ENCRYPT_CONTENT;
             handler.OnCreate(m_pEncryptDict, m_pIDArray, (const uint8_t*)user_pass, user_pass.GetLength(), flag);
-            if (m_pCryptoHandler && m_bNewCrypto) {
+            if (m_bNewCrypto) {
                 delete m_pCryptoHandler;
             }
             m_pCryptoHandler = new CPDF_StandardCryptoHandler;
             m_pCryptoHandler->Init(m_pEncryptDict, &handler);
             m_bNewCrypto = TRUE;
             m_bSecurityChanged = TRUE;
         }
     }
 }
 int32_t CPDF_Creator::Continue(IFX_Pause *pPause)
@@ skipping 33 matching lines @@
 }
 void CPDF_Creator::RemoveSecurity()
 {
     ResetStandardSecurity();
     m_bSecurityChanged = TRUE;
     m_pEncryptDict = NULL;
     m_pCryptoHandler = NULL;
 }
 void CPDF_Creator::ResetStandardSecurity()
 {
-    if ((m_bStandardSecurity || m_bNewCrypto) && m_pCryptoHandler) {
+    if (m_bStandardSecurity || m_bNewCrypto) {
         delete m_pCryptoHandler;
         m_pCryptoHandler = NULL;
     }
     m_bNewCrypto = FALSE;
     if (!m_bStandardSecurity) {
         return;
     }
     if (m_pEncryptDict) {
         m_pEncryptDict->Release();
         m_pEncryptDict = NULL;
     }
     m_bStandardSecurity = FALSE;
 }