Clean-up: Retires obsolete methods in views::Label and views::TextButtonBase.

As part of effort to support multiple fonts, this CL changes methods which are now taking gfx::Font so they will take gfx::FontList instead.

See https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/view

BUG=265485
TEST=Run unit_tests, ui_unittests, views_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245118

[Yuki, 2014-01-06 07:59:40]

Now I believe all the client code of Label and TextButton are rewritten to use
gfx::FontList.  Retires gfx::Font APIs.

[sadrul, 2014-01-06 18:41:04]

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label.cc
File ui/views/controls/label.cc (right):

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label...
ui/views/controls/label.cc:41: Init(base::string16(), gfx::FontList());
Is this gfx::FontList() equivalent to the default font-list from the
ResourceBundle?

[Yuki, 2014-01-07 02:28:35]

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label.cc
File ui/views/controls/label.cc (right):

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label...
ui/views/controls/label.cc:41: Init(base::string16(), gfx::FontList());
On 2014/01/06 18:41:04, sadrul wrote:
> Is this gfx::FontList() equivalent to the default font-list from the
> ResourceBundle?

Yes, it's now equivalent.

[sadrul, 2014-01-07 02:35:32]

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label.cc
File ui/views/controls/label.cc (right):

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label...
ui/views/controls/label.cc:41: Init(base::string16(), gfx::FontList());
On 2014/01/07 02:28:36, Yuki wrote:
> On 2014/01/06 18:41:04, sadrul wrote:
> > Is this gfx::FontList() equivalent to the default font-list from the
> > ResourceBundle?
> 
> Yes, it's now equivalent.

Considering crbug.com/330975, if we get the FontList from the ResourceBundle,
then the FontList here will inherit the cached FontList attributes (e.g.
height), but if we create a new instance of FontList (as you do with this
patch), we lose that, and it would have to recompute that information. Is that
correct? Wouldn't that cause more perf issues?

[Yuki, 2014-01-07 02:41:32]

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label.cc
File ui/views/controls/label.cc (right):

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label...
ui/views/controls/label.cc:41: Init(base::string16(), gfx::FontList());
On 2014/01/07 02:35:32, sadrul wrote:
> On 2014/01/07 02:28:36, Yuki wrote:
> > On 2014/01/06 18:41:04, sadrul wrote:
> > > Is this gfx::FontList() equivalent to the default font-list from the
> > > ResourceBundle?
> > 
> > Yes, it's now equivalent.
> 
> Considering crbug.com/330975, if we get the FontList from the ResourceBundle,
> then the FontList here will inherit the cached FontList attributes (e.g.
> height), but if we create a new instance of FontList (as you do with this
> patch), we lose that, and it would have to recompute that information. Is that
> correct? Wouldn't that cause more perf issues?

That's a good point.  Let me address the issue first.

[Yuki, 2014-01-07 13:00:53]

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label.cc
File ui/views/controls/label.cc (right):

https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label...
ui/views/controls/label.cc:41: Init(base::string16(), gfx::FontList());
On 2014/01/07 02:41:32, Yuki wrote:
> On 2014/01/07 02:35:32, sadrul wrote:
> > On 2014/01/07 02:28:36, Yuki wrote:
> > > On 2014/01/06 18:41:04, sadrul wrote:
> > > > Is this gfx::FontList() equivalent to the default font-list from the
> > > > ResourceBundle?
> > > 
> > > Yes, it's now equivalent.
> > 
> > Considering crbug.com/330975, if we get the FontList from the
ResourceBundle,
> > then the FontList here will inherit the cached FontList attributes (e.g.
> > height), but if we create a new instance of FontList (as you do with this
> > patch), we lose that, and it would have to recompute that information. Is
that
> > correct? Wouldn't that cause more perf issues?
> 
> That's a good point.  Let me address the issue first.

Just FYI, I've sent out a CL: http://crrev.com/124693003

[sadrul, 2014-01-07 17:02:01]

On 2014/01/07 13:00:53, Yuki wrote:
>
https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label.cc
> File ui/views/controls/label.cc (right):
> 
>
https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label...
> ui/views/controls/label.cc:41: Init(base::string16(), gfx::FontList());
> On 2014/01/07 02:41:32, Yuki wrote:
> > On 2014/01/07 02:35:32, sadrul wrote:
> > > On 2014/01/07 02:28:36, Yuki wrote:
> > > > On 2014/01/06 18:41:04, sadrul wrote:
> > > > > Is this gfx::FontList() equivalent to the default font-list from the
> > > > > ResourceBundle?
> > > > 
> > > > Yes, it's now equivalent.
> > > 
> > > Considering crbug.com/330975, if we get the FontList from the
> ResourceBundle,
> > > then the FontList here will inherit the cached FontList attributes (e.g.
> > > height), but if we create a new instance of FontList (as you do with this
> > > patch), we lose that, and it would have to recompute that information. Is
> that
> > > correct? Wouldn't that cause more perf issues?
> > 
> > That's a good point.  Let me address the issue first.
> 
> Just FYI, I've sent out a CL: http://crrev.com/124693003

Cool. Please ping on this CL when this lands.

[sadrul, 2014-01-08 06:39:32]

On 2014/01/07 17:02:01, sadrul wrote:
> On 2014/01/07 13:00:53, Yuki wrote:
> >
>
https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label.cc
> > File ui/views/controls/label.cc (right):
> > 
> >
>
https://codereview.chromium.org/119273002/diff/830001/ui/views/controls/label...
> > ui/views/controls/label.cc:41: Init(base::string16(), gfx::FontList());
> > On 2014/01/07 02:41:32, Yuki wrote:
> > > On 2014/01/07 02:35:32, sadrul wrote:
> > > > On 2014/01/07 02:28:36, Yuki wrote:
> > > > > On 2014/01/06 18:41:04, sadrul wrote:
> > > > > > Is this gfx::FontList() equivalent to the default font-list from the
> > > > > > ResourceBundle?
> > > > > 
> > > > > Yes, it's now equivalent.
> > > > 
> > > > Considering crbug.com/330975, if we get the FontList from the
> > ResourceBundle,
> > > > then the FontList here will inherit the cached FontList attributes (e.g.
> > > > height), but if we create a new instance of FontList (as you do with
this
> > > > patch), we lose that, and it would have to recompute that information.
Is
> > that
> > > > correct? Wouldn't that cause more perf issues?
> > > 
> > > That's a good point.  Let me address the issue first.
> > 
> > Just FYI, I've sent out a CL: http://crrev.com/124693003
> 
> Cool. Please ping on this CL when this lands.

Looks like that CL is in the CQ. So this LGTM

[commit-bot: I haz the power, 2014-01-14 04:51:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/119273002/830001

[commit-bot: I haz the power, 2014-01-14 08:35:03]

Retried try job too often on linux_aura for step(s) app_list_unittests,
aura_unittests, browser_tests, compositor_unittests, content_browsertests,
content_unittests, events_unittests, interactive_ui_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2014-01-16 03:21:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/119273002/1370001

[commit-bot: I haz the power, 2014-01-16 04:50:20]

Change committed as 245118