Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1192723002: Templatize expandSelectionToRespectUserSelectAll in SelectionController (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize expandSelectionToRespectUserSelectAll in SelectionController This patch introduces a template funciton |expandSelectionToRespectUserSelectAllAlgorithm<Strategy>| for a preparation of makeing static function |expandSelectionToRespectUserSelectAll()| to work with both DOM tree and composed tree. Following patch will make |expandSelectionToRespectUserSelectAll()| to check runtime flag |SelectionForWebComponents| and work for either positions in DOM tree or positions in composed tree. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Source/core/editing/SelectionController.cpp View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
linux_chromium_gn_rel failure is caused by configuration issue: /home/chrome-bot/goma/gomacc: not found Details: FAILED: /home/chrome-bot/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD ...
4 years, 10 months ago (2015-06-19 01:16:54 UTC) #1
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-19 02:15:18 UTC) #3
tkent
lgtm
4 years, 10 months ago (2015-06-19 02:18:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192723002/1
4 years, 10 months ago (2015-06-19 02:18:32 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 03:15:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197424

Powered by Google App Engine
This is Rietveld 408576698