Introduce honorEditingBoundaryAtOrBeforeOf() to avoid referencing constructing object

Source/core/editing/VisiblePosition.cpp

Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 046f5b6883f9c9c47e687b62db901d27e73890bd..e16a6c8390860652455358402433bc47181321a2 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -450,12 +450,12 @@ VisiblePosition VisiblePosition::right(bool stayInEditableContent) const
     return directionOfEnclosingBlock(right.deepEquivalent()) == LTR ? honorEditingBoundaryAtOrAfter(right) : honorEditingBoundaryAtOrBefore(right);
 }
 
-VisiblePosition VisiblePosition::honorEditingBoundaryAtOrBefore(const VisiblePosition &pos) const
+VisiblePosition honorEditingBoundaryAtOrBeforeOf(const VisiblePosition& pos, const Position& anchor)

[tkent, 2015/06/19 02:15:57]

Is this |static|?

[yosin_UTC9, 2015/06/19 03:38:12]

No. This function will be called from |startOfLine()|, which is called by
|isSameLine()|.

FYI: Here is current calling sequence:
VisiblePosition ctor
VisiblePosition::init
isSameLine ; which takes *this which is begin constructed
startOfLine
VisiblePosition::honorEditingBoundaryAtOrBefore

I would like to remove constructing |VisiblePosition| reference.

I'll compile above explanation into description.

[tkent, 2015/06/19 03:41:38]

So, the function should be declared in a header file.

[yosin_UTC9, 2015/06/19 04:25:36]

You're right.

At this time, all call sites, actually just one, is in this file. So, I'll mark
this function to |static| rather than adding in to header file to avoid
confusion and make this patch self contained, and I'll add it to header file
when we have another call site to bold what we are doing.

 {
     if (pos.isNull())
         return pos;
 
-    ContainerNode* highestRoot = highestEditableRoot(deepEquivalent());
+    ContainerNode* highestRoot = highestEditableRoot(anchor);
 
     // Return empty position if pos is not somewhere inside the editable region containing this position
     if (highestRoot && !pos.deepEquivalent().deprecatedNode()->isDescendantOf(highestRoot))
@@ -476,6 +476,11 @@ VisiblePosition VisiblePosition::honorEditingBoundaryAtOrBefore(const VisiblePos
     return lastEditableVisiblePositionBeforePositionInRoot(pos.deepEquivalent(), highestRoot);
 }
 
+VisiblePosition VisiblePosition::honorEditingBoundaryAtOrBefore(const VisiblePosition &pos) const
+{
+    return honorEditingBoundaryAtOrBeforeOf(pos, deepEquivalent());
+}
+
 VisiblePosition VisiblePosition::honorEditingBoundaryAtOrAfter(const VisiblePosition &pos) const
 {
     if (pos.isNull())