Introduce honorEditingBoundaryAtOrBeforeOf() to avoid referencing constructing object

Introduce honorEditingBoundaryAtOrBeforeOf() to avoid referencing constructing object

This patch introduces |honorEditingBoundaryAtOrBeforeOf()| from
|VisiblePosition::honorEditingBoundaryAtOrBefore()| to avoid constructing object
reference during |VisiblePositon| construction for making |VisiblePositon| in
composed tree for selection for web component.

Here is current calling sequence:
 - VisibilePosition ctor
 - VisiblePositon init
 - isSameLine (in VisibleUnits.cpp) - called with *this, being constructed
 - startOfLine (in VisibleUnits.cpp)
 - VisbilePosition::honorEditingBoundaryAtOrBefore

To avoid constructing object reference, we'll make |isSameLine()| to take
|PositionWithAffinity| instead of |VisiblePosition|.

This is the first step make |VisiblePostion| to handle a position in composed
tree. Following patches will come:
 - Templatize honorEditingBoundaryAtOrBeforeOf()
 - Templatize inSameLine
 - Introduce VisiblePosition::canonicalize(), as http://crrev.com/1106433002

VisiblePositon within composed tree


This patch is result of collaboration work with hajimehoshi@chromium.org
for selection of web components. After this patch, we are going to
implement another strategies for the composed tree. We've already
prepared that at http://crrev.com/1106433002.

BUG=275851
TEST=n/a; No behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197451

[yosin_UTC9, 2015-06-19 00:49:38]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2015-06-19 01:07:43]

linux_chromium_gn_rel failure is caused by configuration issue: 
/home/chrome-bot/goma/gomacc: not found


Details:
FAILED: /home/chrome-bot/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/sandbox/linux/services/libc_urandom_override.libc_urandom_override.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS
-DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DDONT_EMBED_BUILD_METADATA -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT
-DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1
-DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY
-DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DV8_USE_EXTERNAL_STARTUP_DATA
-DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=239765-1
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fno-strict-aliasing
-fstack-protector --param=ssp-buffer-size=4 -m64 -march=x86-64 -funwind-tables
-fPIC -pipe -pthread -B../../third_party/binutils/Linux_x64/Release/bin
-fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-Wno-inconsistent-missing-override -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin
-Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O2 -fno-ident
-fdata-sections -ffunction-sections -g1 -gsplit-dwarf -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c
../../sandbox/linux/services/libc_urandom_override.cc -o
obj/sandbox/linux/services/libc_urandom_override.libc_urandom_override.o
/bin/sh: 1: /home/chrome-bot/goma/gomacc: not found

[yosin_UTC9, 2015-06-19 02:02:20]

PTAL

[tkent, 2015-06-19 02:15:57]

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisiblePosition.cpp (right):

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisiblePosition.cpp:453: VisiblePosition
honorEditingBoundaryAtOrBeforeOf(const VisiblePosition& pos, const Position&
anchor)
Is this |static|?

[yosin_UTC9, 2015-06-19 03:38:12]

PTAL

mac_blink_rel bot failure,
inspector/sources/debugger-async/async-callstack-xhrs.html, isn't related to
this patch.

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisiblePosition.cpp (right):

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisiblePosition.cpp:453: VisiblePosition
honorEditingBoundaryAtOrBeforeOf(const VisiblePosition& pos, const Position&
anchor)
On 2015/06/19 02:15:57, tkent wrote:
> Is this |static|?

No. This function will be called from |startOfLine()|, which is called by
|isSameLine()|.

FYI: Here is current calling sequence:
VisiblePosition ctor
VisiblePosition::init
isSameLine ; which takes *this which is begin constructed
startOfLine
VisiblePosition::honorEditingBoundaryAtOrBefore

I would like to remove constructing |VisiblePosition| reference.

I'll compile above explanation into description.

[tkent, 2015-06-19 03:41:38]

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisiblePosition.cpp (right):

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisiblePosition.cpp:453: VisiblePosition
honorEditingBoundaryAtOrBeforeOf(const VisiblePosition& pos, const Position&
anchor)
On 2015/06/19 03:38:12, Yosi_UTC9 wrote:
> On 2015/06/19 02:15:57, tkent wrote:
> > Is this |static|?
> 
> No. This function will be called from |startOfLine()|, which is called by
> |isSameLine()|.
> 
> FYI: Here is current calling sequence:
> VisiblePosition ctor
> VisiblePosition::init
> isSameLine ; which takes *this which is begin constructed
> startOfLine
> VisiblePosition::honorEditingBoundaryAtOrBefore
> 
> I would like to remove constructing |VisiblePosition| reference.
> 
> I'll compile above explanation into description.
> 

So, the function should be declared in a header file.

[yosin_UTC9, 2015-06-19 04:25:36]

PTAL

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisiblePosition.cpp (right):

https://codereview.chromium.org/1192713002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisiblePosition.cpp:453: VisiblePosition
honorEditingBoundaryAtOrBeforeOf(const VisiblePosition& pos, const Position&
anchor)
On 2015/06/19 03:41:38, tkent wrote:
> On 2015/06/19 03:38:12, Yosi_UTC9 wrote:
> > On 2015/06/19 02:15:57, tkent wrote:
> > > Is this |static|?
> > 
> > No. This function will be called from |startOfLine()|, which is called by
> > |isSameLine()|.
> > 
> > FYI: Here is current calling sequence:
> > VisiblePosition ctor
> > VisiblePosition::init
> > isSameLine ; which takes *this which is begin constructed
> > startOfLine
> > VisiblePosition::honorEditingBoundaryAtOrBefore
> > 
> > I would like to remove constructing |VisiblePosition| reference.
> > 
> > I'll compile above explanation into description.
> > 
> 
> So, the function should be declared in a header file.
You're right.

At this time, all call sites, actually just one, is in this file. So, I'll mark
this function to |static| rather than adding in to header file to avoid
confusion and make this patch self contained, and I'll add it to header file
when we have another call site to bold what we are doing.

[tkent, 2015-06-19 04:31:46]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-06-19 04:31:46]

lgtm

[commit-bot: I haz the power, 2015-06-19 04:32:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192713002/20001

[commit-bot: I haz the power, 2015-06-19 06:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 06:12:31]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59694)

[yosin_UTC9, 2015-06-19 06:17:18]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-19 06:17:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192713002/20001

[commit-bot: I haz the power, 2015-06-19 07:15:42]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197451