Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: cc/scheduler/compositor_timing_history.h

Issue 1192663005: cc: Measure compositor timing with finer granularity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@modeTimingHistory3
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/compositor_timing_history.h
diff --git a/cc/scheduler/compositor_timing_history.h b/cc/scheduler/compositor_timing_history.h
index 41a8484596de5ae96150b268b2b46a9304980ea3..d64c38f1cbef732b96135191ccfb40f13b58f0cf 100644
--- a/cc/scheduler/compositor_timing_history.h
+++ b/cc/scheduler/compositor_timing_history.h
@@ -25,26 +25,43 @@ class CC_EXPORT CompositorTimingHistory {
void AsValueInto(base::trace_event::TracedValue* state) const;
- virtual base::TimeDelta DrawDurationEstimate() const;
virtual base::TimeDelta BeginMainFrameToCommitDurationEstimate() const;
- virtual base::TimeDelta CommitToActivateDurationEstimate() const;
+ virtual base::TimeDelta CommitToReadyToActivateDurationEstimate() const;
+ virtual base::TimeDelta PrepareTilesDurationEstimate() const;
+ virtual base::TimeDelta ActivateDurationEstimate() const;
+ virtual base::TimeDelta DrawDurationEstimate() const;
+
+ void SetRecordingEnabled(bool enabled);
void WillBeginMainFrame();
+ void BeginMainFrameAborted();
void DidCommit();
- void DidActivateSyncTree();
- void DidStartDrawing();
- void DidFinishDrawing();
+ void WillPrepareTiles();
+ void DidPrepareTiles();
+ void ReadyToActivate();
+ void WillActivate();
+ void DidActivate();
+ void WillDraw();
+ void DidDraw();
protected:
+ virtual base::TimeTicks Now() const;
+
void AddDrawDurationUMA(base::TimeDelta draw_duration,
base::TimeDelta draw_duration_estimate);
- RollingTimeDeltaHistory draw_duration_history_;
+ bool enabled_;
+
RollingTimeDeltaHistory begin_main_frame_to_commit_duration_history_;
mithro-old 2015/06/30 07:55:49 Can we record the delta between when the commit wa
- RollingTimeDeltaHistory commit_to_activate_duration_history_;
+ RollingTimeDeltaHistory commit_to_ready_to_activate_duration_history_;
+ RollingTimeDeltaHistory prepare_tiles_duration_history_;
mithro-old 2015/06/30 07:55:49 It would be interesting in the future to have a wa
+ RollingTimeDeltaHistory activate_duration_history_;
+ RollingTimeDeltaHistory draw_duration_history_;
mithro-old 2015/06/30 07:55:49 I think it would also be useful to record the foll
brianderson 2015/06/30 17:35:15 Acknowledged. Some of those would probably fit be
base::TimeTicks begin_main_frame_sent_time_;
- base::TimeTicks commit_complete_time_;
+ base::TimeTicks commit_time_;
+ base::TimeTicks start_prepare_tiles_time_;
+ base::TimeTicks start_activate_time_;
base::TimeTicks start_draw_time_;
RenderingStatsInstrumentation* rendering_stats_instrumentation_;

Powered by Google App Engine
This is Rietveld 408576698