Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 1192653002: clang/win: Fix component build after https://codereview.chromium.org/1149383004/ (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
hans, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix component build after https://codereview.chromium.org/1149383004/ The compiler may choose to inline ServiceWorkerVersionInfo's assignment operator in clients. The assignment operator needs to assign ClientInfo objects in the clients map<>, which can call ~ClientInfo(). So ClientInfo needs to be exported, as it can be referenced from outside content this way. BUG=82385, 466871 TBR=hans,horo Committed: https://crrev.com/2490eae99cb38140e27dcb3e89fb21385a84f676 Cr-Commit-Position: refs/heads/master@{#334995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_info.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
5 years, 6 months ago (2015-06-18 04:04:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192653002/1
5 years, 6 months ago (2015-06-18 04:05:36 UTC) #4
horo
lgtm
5 years, 6 months ago (2015-06-18 04:09:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 05:21:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2490eae99cb38140e27dcb3e89fb21385a84f676 Cr-Commit-Position: refs/heads/master@{#334995}
5 years, 6 months ago (2015-06-18 05:22:37 UTC) #7
hans
5 years, 6 months ago (2015-06-18 15:50:33 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698