Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: pkg/analysis_server/test/protocol_server_test.dart

Issue 1192603002: (TBR) fix server tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/protocol_server_test.dart
diff --git a/pkg/analysis_server/test/protocol_server_test.dart b/pkg/analysis_server/test/protocol_server_test.dart
index fca8b53cffffe19b60f8a36e28882ae261839283..6c9fedb48013710d551159d0e526e65f958705a4 100644
--- a/pkg/analysis_server/test/protocol_server_test.dart
+++ b/pkg/analysis_server/test/protocol_server_test.dart
@@ -275,8 +275,7 @@ enum E2 { three, four }''');
engine.CompilationUnit unit = resolveLibraryUnit(source);
{
engine.ClassElement engineElement = findElementInUnit(unit, '_E1');
- // TODO (danrubel) determine why enum is not deprecated
- expect(engineElement.isDeprecated, isFalse);
+ expect(engineElement.isDeprecated, isTrue);
// create notification Element
Element element = newElement_fromEngine(engineElement);
expect(element.kind, ElementKind.ENUM);
@@ -329,11 +328,11 @@ enum E2 { three, four }''');
expect(element.parameters, isNull);
expect(element.returnType, '_E1');
// TODO(danrubel) determine why enum constant is not marked as deprecated
- engine.ClassElement classElement = engineElement.enclosingElement;
+ //engine.ClassElement classElement = engineElement.enclosingElement;
+ //expect(classElement.isDeprecated, isTrue);
expect(element.flags,
- (classElement.isDeprecated ? Element.FLAG_DEPRECATED : 0) |
- Element.FLAG_CONST |
- Element.FLAG_STATIC);
+ // Element.FLAG_DEPRECATED |
+ Element.FLAG_CONST | Element.FLAG_STATIC);
}
{
engine.FieldElement engineElement = findElementInUnit(unit, 'three');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698