Issue 11926025: Remove <(library) usage from hunspell.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11926025: Remove <(library) usage from hunspell.gyp. (Closed)

Created:
7 years, 11 months ago by tfarina

Modified:
7 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/hunspell/

Visibility:
Public.

More Reviews

Description

Remove <(library) usage from hunspell.gyp. BUG=111541 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177853

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	hunspell.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

7 years, 11 months ago (2013-01-18 22:40:00 UTC) #2

lgtm

On Fri, Jan 18, 2013 at 2:39 PM,  <tfarina@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Remove <(library) usage from hunspell.gyp.
>
> BUG=111541
> R=thakis@chromium.org
>
> Please review this at https://codereview.chromium.org/11926025/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/hunspell/
>
> Affected files:
>   M     hunspell.gyp
>
>
> Index: hunspell.gyp
> ===================================================================
> --- hunspell.gyp        (revision 177780)
> +++ hunspell.gyp        (working copy)
> @@ -6,7 +6,7 @@
>    'targets': [
>      {
>        'target_name': 'hunspell',
> -      'type': '<(library)',
> +      'type': 'static_library',
>        'msvs_guid': 'D5E8DCB2-9C61-446F-8BEE-B18CA0E0936E',
>        'dependencies': [
>          '../../base/base.gyp:base',
>
>

Expand Messages | Collapse Messages