Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1192583002: Revert of views: Move TOOLKIT_VIEWS definition in //ui/views/ from root. (Closed)

Created:
5 years, 6 months ago by phoglund_chromium
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tapted, Matt Giuca, extensions-reviews_chromium.org, tfarina, noyau+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of views: Move TOOLKIT_VIEWS definition in //ui/views/ from root. (patchset #6 id:100001 of https://codereview.chromium.org/1175603002/) Reason for revert: Speculative revert to fix win unit_test failures. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/39651 Original issue's description: > views: Move TOOLKIT_VIEWS definition in //ui/views/ from root. > > If 'toolkit_views' gyp/gn flag is toggled, then it shouldn't cause targets that > do not depend on views to be rebuilt. To make this happen, remove the definition > of the TOOLKIT_VIEWS flag from the top-level config into a config in views, so > that only targets that explicitly depend on views get the define, and are > affected by the switch. > > BUG=500004 > R=ben@chromium.org, sky@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/c13fc9ff0aedca62ebfdfc27d44c6b5ac204c9d8 TBR=ben@chromium.org,sky@chromium.org,sadrul@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=500004 Committed: https://crrev.com/ecbf7e40116d555c11ee958b6339618920d11c2c Cr-Commit-Position: refs/heads/master@{#334820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -56 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M components/bookmarks.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/native_widget_types.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
phoglund_chromium
Created Revert of views: Move TOOLKIT_VIEWS definition in //ui/views/ from root.
5 years, 6 months ago (2015-06-17 13:41:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192583002/1
5 years, 6 months ago (2015-06-17 13:42:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 13:44:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ecbf7e40116d555c11ee958b6339618920d11c2c Cr-Commit-Position: refs/heads/master@{#334820}
5 years, 6 months ago (2015-06-17 13:45:03 UTC) #4
phoglund_chromium
On 2015/06/17 13:45:03, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 6 months ago (2015-06-17 19:20:34 UTC) #5
paulmeyer
5 years, 6 months ago (2015-06-17 21:19:31 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1182053007/ by paulmeyer@chromium.org.

The reason for reverting is: Unreverting because this CL did not end up being
the problem..

Powered by Google App Engine
This is Rietveld 408576698