src/compiler/typer.h - Issue 1192553002: [turbofan] Fix life time and use of the Typer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/typer.h

Issue 1192553002: [turbofan] Fix life time and use of the Typer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/typer.h

diff --git a/src/compiler/typer.h b/src/compiler/typer.h

index 4c04ddb973b3404b85a2522fc9c75003041d0b10..68d1a4dd29203343dd8869d2b5e6c7e692c664e4 100644

--- a/src/compiler/typer.h

+++ b/src/compiler/typer.h

@@ -21,7 +21,9 @@ class Typer {

Typer(Isolate* isolate, Graph* graph, MaybeHandle<Context> context);

~Typer();

+ // TODO(bmeurer,jarin): Remove this once we have a notion of "roots" on Graph.

Michael Starzinger 2015/06/17 11:32:23 nit: Either move the TODO one line lower or drop i

Benedikt Meurer 2015/06/17 11:38:13 Done.

void Run();

+ void Run(const ZoneVector<Node*>& roots);

Graph* graph() { return graph_; }

MaybeHandle<Context> context() { return context_; }