[turbofan] Fix life time and use of the Typer.

[turbofan] Fix life time and use of the Typer.

Currently the Typer is installed on the Graph, no matter if we actually
use the types or not (read: even in the generic pipeline). Also the
Typer tries hard to eagerly type nodes during graph building, which
takes time, just to remove those types later again, and retype
everything from scratch. Plus this is inconsistent, since it only
applies to the outermost graph, not the inlined graphs (which are
eagerly typed once the nodes are copied). So in summary, what's
currently implemented is neither useful nor well defined, so for now we
stick to the full typing approach until a proper design for eager typing
is available that will actually benefit us.

R=rossberg@chromium.org,mstarzinger@chromium.org,jarin@chromium.org

Committed: https://crrev.com/a4f060278f18c38bb77d5cb41c72d7f6d3f270f6
Cr-Commit-Position: refs/heads/master@{#29086}

[Benedikt Meurer, 2015-06-17 11:21:20]

Hey Michi, Andreas, Jaro,

As discussed offline. We'll use this as an intermediate step to make progress.
We can still do eager typing if someone comes up with a solution that works and
benefits us.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2015-06-17 11:32:23]

LGTM, only nits.

https://codereview.chromium.org/1192553002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1192553002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:288: // TODO(dcarney): make this into a ZoneObject.
nit: TODO no longer applies, let's drop it.

https://codereview.chromium.org/1192553002/diff/1/src/compiler/typer.h
File src/compiler/typer.h (right):

https://codereview.chromium.org/1192553002/diff/1/src/compiler/typer.h#newcode24
src/compiler/typer.h:24: // TODO(bmeurer,jarin): Remove this once we have a
notion of "roots" on Graph.
nit: Either move the TODO one line lower or drop it completely.

[Benedikt Meurer, 2015-06-17 11:38:13]

https://codereview.chromium.org/1192553002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1192553002/diff/1/src/compiler/pipeline.cc#ne...
src/compiler/pipeline.cc:288: // TODO(dcarney): make this into a ZoneObject.
On 2015/06/17 11:32:23, Michael Starzinger wrote:
> nit: TODO no longer applies, let's drop it.

Done.

https://codereview.chromium.org/1192553002/diff/1/src/compiler/typer.h
File src/compiler/typer.h (right):

https://codereview.chromium.org/1192553002/diff/1/src/compiler/typer.h#newcode24
src/compiler/typer.h:24: // TODO(bmeurer,jarin): Remove this once we have a
notion of "roots" on Graph.
On 2015/06/17 11:32:23, Michael Starzinger wrote:
> nit: Either move the TODO one line lower or drop it completely.

Done.

[Jarin, 2015-06-17 11:38:20]

lgtm

[rossberg, 2015-06-17 11:40:11]

lgtm

[Benedikt Meurer, 2015-06-17 11:40:39]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-06-17 11:40:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1192553002/#ps20001
(title: "Address Michis comments.")

[commit-bot: I haz the power, 2015-06-17 11:40:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192553002/20001

[commit-bot: I haz the power, 2015-06-17 12:25:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-17 12:25:12]

Patchset 2 (id:??) landed as
https://crrev.com/a4f060278f18c38bb77d5cb41c72d7f6d3f270f6
Cr-Commit-Position: refs/heads/master@{#29086}