Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1192533002: Fix stocks app test (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Enable render view override for stocks app to enable testing This fixes the test TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/16ed6a9516777725cb332193403d3537902c93f4

Patch Set 1 #

Patch Set 2 : add missing import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jackson
5 years, 6 months ago (2015-06-17 06:37:10 UTC) #1
jackson
Committed patchset #2 (id:20001) manually as 16ed6a9516777725cb332193403d3537902c93f4 (presubmit successful).
5 years, 6 months ago (2015-06-17 06:37:33 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-17 06:39:46 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698