Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(227)

Issue 1192503002: Make explicit default parameters for applyTransform (Closed)

Created:
4 years, 10 months ago by soonm
Modified:
4 years, 10 months ago
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, kouhei+svg_chromium.org, blink-reviews-style_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make explicit default parameters for applyTransform. There are no changes to functional behaviour. It aims to clarify the calls to applyTransform so it is more obvious whether motion-path is being applied to the transform. BUG=496550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197327

Patch Set 1 #

Patch Set 2 : Rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/ComputedStyle.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Timothy Loh
lgtm
4 years, 10 months ago (2015-06-18 03:14:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192503002/1
4 years, 10 months ago (2015-06-18 05:39:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/47876) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
4 years, 10 months ago (2015-06-18 05:43:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192503002/40001
4 years, 10 months ago (2015-06-18 06:20:29 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 07:47:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197327

Powered by Google App Engine
This is Rietveld 408576698