Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: components/password_manager/core/browser/login_database.h

Issue 1192493005: Encrypt password values in LoginDatabase on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database.h
diff --git a/components/password_manager/core/browser/login_database.h b/components/password_manager/core/browser/login_database.h
index ca3db84438e09ffb6d07e3d4ab36b2d109eaba92..96257e7eae4325d17d514639ba03a743f115a581 100644
--- a/components/password_manager/core/browser/login_database.h
+++ b/components/password_manager/core/browser/login_database.h
@@ -111,6 +111,8 @@ class LoginDatabase {
StatisticsTable& stats_table() { return stats_table_; }
+ void set_clear_password_values(bool val) { clear_password_values_ = val; }
+
private:
// Result values for encryption/decryption actions.
enum EncryptionResult {
@@ -170,6 +172,13 @@ class LoginDatabase {
sql::MetaTable meta_table_;
StatisticsTable stats_table_;
+ // If set to 'true', then the password values are cleared before encrypting
+ // and storing in the database. At the same time AddLogin/UpdateLogin return
+ // PasswordStoreChangeList containing the real password.
+ // This is a temporary measure for migration the Keychain on Mac.
+ // crbug.com/466638
+ bool clear_password_values_;
+
DISALLOW_COPY_AND_ASSIGN(LoginDatabase);
};

Powered by Google App Engine
This is Rietveld 408576698