Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1192473003: Revert "Add Unicode Variation Selector support to harfBuzzGetGlyph" (Closed)

Created:
5 years, 6 months ago by kojii
Modified:
5 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Add Unicode Variation Selector support to harfBuzzGetGlyph" This reverts commit 560bd94f6c3a9c8e6c3b437f01908730dc055832. NOTRY=True TBR=eae BUG=383580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -94 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/text/unicode-variation-selector.html View 1 chunk +5 lines, -22 lines 0 comments Download
D LayoutTests/fast/text/unicode-variation-selector-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
A LayoutTests/platform/android/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/android/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/android/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/android/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac-lion/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac-snowleopard/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac-snowleopard/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/win-xp/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win-xp/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/win-xp/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win-xp/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/win/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/win/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win/virtual/antialiasedtext/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/platform/win/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win/virtual/slimmingpaint/fast/text/unicode-variation-selector-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzFace.cpp View 3 chunks +6 lines, -26 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.h View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192473003/1
5 years, 6 months ago (2015-06-18 04:28:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197318
5 years, 6 months ago (2015-06-18 04:34:41 UTC) #3
eae
5 years, 6 months ago (2015-06-18 15:44:36 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698