Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: Source/core/paint/LayerFixedPositionRecorder.cpp

Issue 1192443003: [Slimming Paint] Blink-side contiguous allocation of display items. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: need a constructor with WTF_MAKE_NONCOPYABLE Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/LayerClipRecorder.cpp ('k') | Source/core/paint/RoundedInnerRectClipper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/LayerFixedPositionRecorder.cpp
diff --git a/Source/core/paint/LayerFixedPositionRecorder.cpp b/Source/core/paint/LayerFixedPositionRecorder.cpp
index 966c99925587a33f5481c0efa860ab0e7d717692..a9ff53ca4187d8b00b4de648d4bc9430b6981a38 100644
--- a/Source/core/paint/LayerFixedPositionRecorder.cpp
+++ b/Source/core/paint/LayerFixedPositionRecorder.cpp
@@ -26,14 +26,18 @@ LayerFixedPositionRecorder::LayerFixedPositionRecorder(GraphicsContext& graphics
if (m_graphicsContext.displayItemList()->displayItemConstructionIsDisabled())
return;
- if (m_isFixedPosition)
- m_graphicsContext.displayItemList()->add(BeginFixedPositionDisplayItem::create(m_layoutObject));
+ if (m_isFixedPosition) {
+ BeginFixedPositionDisplayItem beginFixed(m_layoutObject);
+ m_graphicsContext.displayItemList()->add(beginFixed);
+ }
// TODO(trchen): Adding a pair of display items on every transformed
// element can be expensive. Investigate whether we can optimize out some
// of them if applicable.
- if (m_isFixedPositionContainer)
- m_graphicsContext.displayItemList()->add(BeginFixedPositionContainerDisplayItem::create(m_layoutObject));
+ if (m_isFixedPositionContainer) {
+ BeginFixedPositionContainerDisplayItem beginContainer(m_layoutObject);
+ m_graphicsContext.displayItemList()->add(beginContainer);
+ }
}
LayerFixedPositionRecorder::~LayerFixedPositionRecorder()
@@ -44,11 +48,15 @@ LayerFixedPositionRecorder::~LayerFixedPositionRecorder()
if (m_graphicsContext.displayItemList()->displayItemConstructionIsDisabled())
return;
- if (m_isFixedPositionContainer)
- m_graphicsContext.displayItemList()->add(EndFixedPositionContainerDisplayItem::create(m_layoutObject));
+ if (m_isFixedPositionContainer) {
+ EndFixedPositionContainerDisplayItem endContainer(m_layoutObject);
+ m_graphicsContext.displayItemList()->add(endContainer);
+ }
- if (m_isFixedPosition)
- m_graphicsContext.displayItemList()->add(EndFixedPositionDisplayItem::create(m_layoutObject));
+ if (m_isFixedPosition) {
+ EndFixedPositionDisplayItem endFixed(m_layoutObject);
+ m_graphicsContext.displayItemList()->add(endFixed);
+ }
}
} // namespace blink
« no previous file with comments | « Source/core/paint/LayerClipRecorder.cpp ('k') | Source/core/paint/RoundedInnerRectClipper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698