Source/web/WebViewImpl.h - Issue 1192433010: Use Android's "scroll focused node into view" path on all platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 1192433010: Use Android's "scroll focused node into view" path on all platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index f222ca0b0861a8aa1f88560ad2d29f186cd78865..b5499e88c02e92c0434dd7473471bb7ddcdf541a 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -464,7 +464,7 @@ public:

Node* bestTapNode(const GestureEventWithHitTestResults& targetedTapEvent);

void enableTapHighlightAtPoint(const GestureEventWithHitTestResults& targetedTapEvent);

void enableTapHighlights(WillBeHeapVector<RawPtrWillBeMember<Node>>&);

- void computeScaleAndScrollForFocusedNode(Node* focusedNode, float& scale, IntPoint& scroll, bool& needAnimation);

+ void computeScaleAndScrollForFocusedNode(Node* focusedNode, bool zoomInToLegibleScale, float& scale, IntPoint& scroll, bool& needAnimation);

void animateDoubleTapZoom(const IntPoint&);

« no previous file with comments | « no previous file | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »