Use Android's "scroll focused node into view" path on all platforms

Use Android's "scroll focused node into view" path on all platforms

Android and desktop took two different paths to bring a focused editable text
box into view. Desktop would instantaneously set the scroll offset using
ScrollableArea::scrollIntoRect while Android uses a compositor
PageScaleAnimation to smoothly scale and scroll the viewport to fit the
textbox into the viewport.

This patch makes desktop use the Android path but without the zoom
functionality. This unifies the code paths and gives a nicer experience as we
get a smooth scroll rather than an instantaneous jump.

This patch also cleans up the Android path to use the coordinate space
conversion methods provided by PinchViewport and FrameView, rather than doing it
manually.

BUG=484733
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197484

[bokan, 2015-06-17 20:51:24]

bokan@chromium.org changed reviewers:
+ aelias@chromium.org

[bokan, 2015-06-17 20:51:24]

ptal.

[aelias_OOO_until_Jul13, 2015-06-17 21:18:22]

Looks fine.  I'm glad to see the platforms unified here.  I think your
description should say that this affects all desktop platforms, not just
ChromeOS?

Could you add a test for the zoomInToLegibleScale = false case?

[bokan, 2015-06-18 16:25:21]

On 2015/06/17 21:18:22, aelias wrote:
> Looks fine.  I'm glad to see the platforms unified here.  I think your
> description should say that this affects all desktop platforms, not just
> ChromeOS?
> 
Hmm...I'm not sure if other platforms use the same IME path but in theory it's
platform agnostic now so done.

> Could you add a test for the zoomInToLegibleScale = false case?
Done.

[aelias_OOO_until_Jul13, 2015-06-18 18:30:22]

lgtm

[bokan, 2015-06-19 14:35:04]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-06-19 14:35:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192433010/20001

[commit-bot: I haz the power, 2015-06-19 15:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 15:49:03]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59784)

[bokan, 2015-06-19 15:49:31]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-06-19 15:49:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192433010/20001

[commit-bot: I haz the power, 2015-06-19 16:37:33]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197484