Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 1192433006: SkSemaphore: use SYNC_POLICY_LIFO on Mach. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkSemaphore: use SYNC_POLICY_LIFO on Mach. Turns out _LIFO does work as we expected, keeping N < M threads active when we have M live threads but only N units of work to do at a time. Also as we expected _FIFO does round-robin through the threads. Performance doesn't seem to be affected, but let's do it anyway. If nothing else this makes profiles a little easier to read. I don't see POSIX or Windows equivalents. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2a4685f8bb1bf3cf098c5fee78a71e2f4204e428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkSemaphore.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 6 months ago (2015-06-17 18:14:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192433006/1
5 years, 6 months ago (2015-06-17 18:14:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 18:20:12 UTC) #6
bungeman-skia
lgtm
5 years, 6 months ago (2015-06-17 18:48:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192433006/1
5 years, 6 months ago (2015-06-17 18:48:23 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 18:49:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2a4685f8bb1bf3cf098c5fee78a71e2f4204e428

Powered by Google App Engine
This is Rietveld 408576698