Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1192433003: Revert of Add %TypedArray% to proto chain (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add %TypedArray% to proto chain (patchset #6 id:100001 of https://codereview.chromium.org/1186733002/) Reason for revert: [Sheriff] Changes layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/429 See e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/429/layout-test-results/inspector/console/console-big-array-pretty-diff.html Please upload a blink side needsmanualrebaseline change first for these tests if the change is intended. Please also add a blink trybot on a reland of this CL. Original issue's description: > Add %TypedArray% to proto chain > > According to the ES6 spec, the main methods and getters shouldn't > be properties of the individual TypedArray objects and prototypes > but instead on %TypedArray% and %TypedArray%.prototype. This > difference is observable through introspection. This patch moves > some methods and getters to the proper place, with the exception > of %TypedArray%.prototype.subarray and harmony methods. These will > be moved in follow-on patches. > > BUG=v8:4085 > LOG=Y > R=adamk > > Committed: https://crrev.com/a10590158260737b256fac3254b4939f48f90095 > Cr-Commit-Position: refs/heads/master@{#29057} TBR=adamk@chromium.org,arv@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Committed: https://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e Cr-Commit-Position: refs/heads/master@{#29070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -173 lines) Patch
M src/harmony-typedarray.js View 3 chunks +45 lines, -38 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/typedarray.js View 3 chunks +43 lines, -57 lines 0 comments Download
M test/mjsunit/es6/built-in-accessor-names.js View 2 chunks +9 lines, -17 lines 0 comments Download
M test/mjsunit/get-prototype-of.js View 3 chunks +9 lines, -17 lines 0 comments Download
M test/mjsunit/harmony/sharedarraybuffer.js View 3 chunks +8 lines, -11 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 3 chunks +8 lines, -11 lines 0 comments Download
M test/mjsunit/harmony/typedarrays-of.js View 2 chunks +2 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-typedarray-length.js View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Add %TypedArray% to proto chain
5 years, 6 months ago (2015-06-17 09:05:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192433003/1
5 years, 6 months ago (2015-06-17 09:05:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 09:05:40 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 09:06:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4d3e1ceba6553b1a10326965f28f46a6653489e
Cr-Commit-Position: refs/heads/master@{#29070}

Powered by Google App Engine
This is Rietveld 408576698