Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1192413002: MIPS64: Fix random failures of fannkuch.js. (Closed)

Created:
5 years, 6 months ago by dusmil.imgtec
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix random failures of fannkuch.js. TEST=mjsunit/asm/embenchen/fannkuch, mjsunit/math-abs BUG= Committed: https://crrev.com/e8173e4ea2fd4b98d2f4c62fbae55b4831f388fb Cr-Commit-Position: refs/heads/master@{#29157}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Patch Set 3 : Addressed comments 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M src/mips64/lithium-codegen-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M test/mjsunit/math-abs.js View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dusmil.imgtec
PTAL.
5 years, 6 months ago (2015-06-19 13:40:06 UTC) #2
paul.l...
LGTM. We need v8 team review of the regression test addition, PTAL.
5 years, 6 months ago (2015-06-19 13:45:19 UTC) #3
Jakob Kummerow
LGTM with comments. I'm shocked that we didn't have test coverage for Math.abs(kMinInt) yet. https://codereview.chromium.org/1192413002/diff/1/test/mjsunit/math-abs.js ...
5 years, 6 months ago (2015-06-19 14:50:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192413002/40001
5 years, 6 months ago (2015-06-19 15:46:05 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-19 16:11:49 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 16:12:03 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e8173e4ea2fd4b98d2f4c62fbae55b4831f388fb
Cr-Commit-Position: refs/heads/master@{#29157}

Powered by Google App Engine
This is Rietveld 408576698