Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Side by Side Diff: src/ic/ic.h

Issue 1192383003: Fix overlapping KeyedLoadIC bitfield. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/ic-state.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_H_ 5 #ifndef V8_IC_H_
6 #define V8_IC_H_ 6 #define V8_IC_H_
7 7
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 static void Clear(Isolate* isolate, Address address, Code* target, 437 static void Clear(Isolate* isolate, Address address, Code* target,
438 Address constant_pool); 438 Address constant_pool);
439 439
440 friend class IC; 440 friend class IC;
441 }; 441 };
442 442
443 443
444 class KeyedLoadIC : public LoadIC { 444 class KeyedLoadIC : public LoadIC {
445 public: 445 public:
446 // ExtraICState bits (building on IC) 446 // ExtraICState bits (building on IC)
447 class IcCheckTypeField : public BitField<IcCheckType, 2, 1> {}; 447 class IcCheckTypeField
448 : public BitField<IcCheckType, LoadICState::kNextBitFieldOffset, 1> {};
448 449
449 static ExtraICState ComputeExtraICState(ContextualMode contextual_mode, 450 static ExtraICState ComputeExtraICState(ContextualMode contextual_mode,
450 LanguageMode language_mode, 451 LanguageMode language_mode,
451 IcCheckType key_type) { 452 IcCheckType key_type) {
452 return LoadICState(contextual_mode, language_mode).GetExtraICState() | 453 return LoadICState(contextual_mode, language_mode).GetExtraICState() |
453 IcCheckTypeField::encode(key_type); 454 IcCheckTypeField::encode(key_type);
454 } 455 }
455 456
456 static IcCheckType GetKeyType(ExtraICState extra_state) { 457 static IcCheckType GetKeyType(ExtraICState extra_state) {
457 return IcCheckTypeField::decode(extra_state); 458 return IcCheckTypeField::decode(extra_state);
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 748
748 // Support functions for interceptor handlers. 749 // Support functions for interceptor handlers.
749 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly); 750 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly);
750 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor); 751 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor);
751 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor); 752 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor);
752 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor); 753 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor);
753 } 754 }
754 } // namespace v8::internal 755 } // namespace v8::internal
755 756
756 #endif // V8_IC_H_ 757 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « no previous file | src/ic/ic-state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698