Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1192373003: Do not fail on images that are too small to subset decode (Closed)

Created:
5 years, 6 months ago by msarett
Modified:
5 years, 6 months ago
Reviewers:
scroggo, emmaleer, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do not fail on images that are too small to subset decode. Specifically (0x0) images being produced by webp scaled decodes are causing problems. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7054257de9ab53a9daf97e51d5e20178c9604e67

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
msarett
5 years, 6 months ago (2015-06-19 13:15:58 UTC) #4
msarett
Adding Emmalee
5 years, 6 months ago (2015-06-19 13:39:03 UTC) #6
scroggo
lgtm. It seems weird that we ever made this a fatal error to begin with...
5 years, 6 months ago (2015-06-19 14:23:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192373003/40001
5 years, 6 months ago (2015-06-19 14:29:32 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 14:44:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://skia.googlesource.com/skia/+/7054257de9ab53a9daf97e51d5e20178c9604e67

Powered by Google App Engine
This is Rietveld 408576698