chrome/browser/autocomplete/search_provider_unittest.cc - Issue 1192373002: Prepare AutocompleteController for componentization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 1192373002: Prepare AutocompleteController for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_zero_suggest_provider

Patch Set: Remove stale include Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc ('K') | « chrome/browser/autocomplete/history_quick_provider_unittest.cc ('k') | chrome/browser/ui/app_list/search/omnibox_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/search_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc

index e65963786a6beed66352280d3521ff13efbb22d0..d5b8176a2768dafcbdf0dc1a2d349e04ad41872c 100644

--- a/chrome/browser/autocomplete/search_provider_unittest.cc

+++ b/chrome/browser/autocomplete/search_provider_unittest.cc

@@ -1128,9 +1128,9 @@ TEST_F(SearchProviderTest, KeywordOrderingAndDescriptions) {

AddSearchToHistory(keyword_t_url_, ASCIIToUTF16("term2"), 1);

profile_.BlockUntilHistoryProcessesPendingRequests();

- AutocompleteController controller(&profile_,

- TemplateURLServiceFactory::GetForProfile(&profile_),

- NULL, AutocompleteProvider::TYPE_SEARCH);

+ AutocompleteController controller(

+ make_scoped_ptr(new ChromeAutocompleteProviderClient(&profile_)), NULL,

Peter Kasting 2015/06/19 19:19:21 Nit: While here: nullptr

blundell 2015/06/22 09:01:36 Done.

+ AutocompleteProvider::TYPE_SEARCH);

controller.Start(AutocompleteInput(

ASCIIToUTF16("k t"), base::string16::npos, std::string(), GURL(),

metrics::OmniboxEventProto::INVALID_SPEC, false, false, true, true, false,