chrome/browser/ui/webui/options/home_page_overlay_handler.cc - Issue 1192373002: Prepare AutocompleteController for componentization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/home_page_overlay_handler.cc

Issue 1192373002: Prepare AutocompleteController for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_zero_suggest_provider

Patch Set: Response to review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc ('k') | chrome/browser/ui/webui/options/startup_pages_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/home_page_overlay_handler.cc

diff --git a/chrome/browser/ui/webui/options/home_page_overlay_handler.cc b/chrome/browser/ui/webui/options/home_page_overlay_handler.cc

index 41ef9806c46d6f34a2a35f5941447e3fd88d819f..1aae897c4f9d0ac3e2acf51612ac3d3dcf81348b 100644

--- a/chrome/browser/ui/webui/options/home_page_overlay_handler.cc

+++ b/chrome/browser/ui/webui/options/home_page_overlay_handler.cc

@@ -9,6 +9,7 @@

#include "base/values.h"

#include "chrome/browser/autocomplete/autocomplete_classifier.h"

#include "chrome/browser/autocomplete/autocomplete_controller.h"

+#include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"

#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

@@ -35,8 +36,8 @@ void HomePageOverlayHandler::RegisterMessages() {

void HomePageOverlayHandler::InitializeHandler() {

Profile* profile = Profile::FromWebUI(web_ui());

- autocomplete_controller_.reset(new AutocompleteController(profile,

- TemplateURLServiceFactory::GetForProfile(profile), this,

+ autocomplete_controller_.reset(new AutocompleteController(

+ make_scoped_ptr(new ChromeAutocompleteProviderClient(profile)), this,

AutocompleteClassifier::kDefaultOmniboxProviders));

}

« no previous file with comments | « chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc ('k') | chrome/browser/ui/webui/options/startup_pages_handler.cc » ('j') | no next file with comments »