chrome/browser/autocomplete/history_quick_provider_unittest.cc - Issue 1192373002: Prepare AutocompleteController for componentization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_quick_provider_unittest.cc

Issue 1192373002: Prepare AutocompleteController for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_zero_suggest_provider

Patch Set: Response to review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc ('k') | chrome/browser/autocomplete/keyword_extensions_delegate_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_quick_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/history_quick_provider_unittest.cc b/chrome/browser/autocomplete/history_quick_provider_unittest.cc

index 46520439ac18a9f21494070901e412a11100ecd0..7be9b01e859e98de136d576a1f668280854422a8 100644

--- a/chrome/browser/autocomplete/history_quick_provider_unittest.cc

+++ b/chrome/browser/autocomplete/history_quick_provider_unittest.cc

@@ -236,13 +236,13 @@ void HistoryQuickProviderTest::SetUp() {

history_service_ = HistoryServiceFactory::GetForProfile(

profile_.get(), ServiceAccessType::EXPLICIT_ACCESS);

EXPECT_TRUE(history_service_);

- InMemoryURLIndex* index =

- InMemoryURLIndexFactory::GetForProfile(profile_.get());

- EXPECT_TRUE(index);

- provider_ = new HistoryQuickProvider(client_.get(), index);

+ provider_ = new HistoryQuickProvider(client_.get());

TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(

profile_.get(), &HistoryQuickProviderTest::CreateTemplateURLService);

FillData();

+ InMemoryURLIndex* index =

+ InMemoryURLIndexFactory::GetForProfile(profile_.get());

+ EXPECT_TRUE(index);

index->RebuildFromHistory(history_backend()->db());

}