Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: Source/platform/graphics/paint/ClipDisplayItem.h

Issue 1192363005: Move all clip display item parameters to the constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/RoundedInnerRectClipper.cpp ('k') | Source/platform/graphics/paint/ClipDisplayItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/ClipDisplayItem.h
diff --git a/Source/platform/graphics/paint/ClipDisplayItem.h b/Source/platform/graphics/paint/ClipDisplayItem.h
index 08ad31a99f660a39247ec1f114d6e4dae4ea6558..65c2754a49998a4ca2ec0a0e53851cdc10ecee6a 100644
--- a/Source/platform/graphics/paint/ClipDisplayItem.h
+++ b/Source/platform/graphics/paint/ClipDisplayItem.h
@@ -18,14 +18,15 @@ namespace blink {
class PLATFORM_EXPORT ClipDisplayItem : public PairedBeginDisplayItem {
WTF_MAKE_FAST_ALLOCATED(ClipDisplayItem);
public:
- static PassOwnPtr<ClipDisplayItem> create(const DisplayItemClientWrapper& client, Type type, const IntRect& clipRect)
+ static PassOwnPtr<ClipDisplayItem> create(const DisplayItemClientWrapper& client, Type type, const IntRect& clipRect, PassOwnPtr<Vector<FloatRoundedRect>> roundedRectClips = nullptr)
{
- return adoptPtr(new ClipDisplayItem(client, type, clipRect));
+ return adoptPtr(new ClipDisplayItem(client, type, clipRect, roundedRectClips));
}
- ClipDisplayItem(const DisplayItemClientWrapper& client, Type type, const IntRect& clipRect)
+ ClipDisplayItem(const DisplayItemClientWrapper& client, Type type, const IntRect& clipRect, PassOwnPtr<Vector<FloatRoundedRect>> roundedRectClips = nullptr)
: PairedBeginDisplayItem(client, type)
, m_clipRect(clipRect)
+ , m_roundedRectClips(roundedRectClips)
{
ASSERT(isClipType(type));
}
@@ -33,14 +34,12 @@ public:
virtual void replay(GraphicsContext&) override;
virtual void appendToWebDisplayItemList(WebDisplayItemList*) const override;
- Vector<FloatRoundedRect>& roundedRectClips() { return m_roundedRectClips; }
-
private:
#ifndef NDEBUG
virtual void dumpPropertiesAsDebugString(WTF::StringBuilder&) const override;
#endif
IntRect m_clipRect;
- Vector<FloatRoundedRect> m_roundedRectClips;
+ OwnPtr<Vector<FloatRoundedRect>> m_roundedRectClips;
};
class PLATFORM_EXPORT EndClipDisplayItem : public PairedEndDisplayItem {
« no previous file with comments | « Source/core/paint/RoundedInnerRectClipper.cpp ('k') | Source/platform/graphics/paint/ClipDisplayItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698