Move all clip display item parameters to the constructor

Source/core/paint/BoxClipper.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/BoxClipper.h"
 
 #include "core/layout/LayoutBox.h"
 #include "core/paint/DeprecatedPaintLayer.h"
 #include "core/paint/PaintInfo.h"
@@ skipping 34 matching lines @@
         LayoutRect conservativeClipRect = clipRect;
         if (hasBorderRadius)
             conservativeClipRect.intersect(LayoutRect(clipRoundedRect.radiusCenterRect()));
         conservativeClipRect.moveBy(-m_accumulatedOffset);
         if (m_box.hasLayer())
             conservativeClipRect.move(m_box.scrolledContentOffset());
         if (conservativeClipRect.contains(contentsVisualOverflow))
             return;
     }
 
-    if (RuntimeEnabledFeatures::slimmingPaintEnabled())
+    OwnPtr<Vector<FloatRoundedRect>> roundedRects;
+    if (hasBorderRadius) {
+        roundedRects = adoptPtr(new Vector<FloatRoundedRect>());

[chrishtr, 2015/06/19 22:10:17]

How about putting the vector on the stack, and requiring the argument? Then pass
by value to copy the vector elements.

+        roundedRects->append(clipRoundedRect);
+    }
+
+    OwnPtr<ClipDisplayItem> clipDisplayItem = ClipDisplayItem::create(m_box, m_clipType, pixelSnappedIntRect(clipRect), roundedRects.release());
+    if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
         m_clipType = m_paintInfo.displayItemTypeForClipping();
-
-    OwnPtr<ClipDisplayItem> clipDisplayItem = ClipDisplayItem::create(m_box, m_clipType, pixelSnappedIntRect(clipRect));
-    if (hasBorderRadius)
-        clipDisplayItem->roundedRectClips().append(clipRoundedRect);
-
-    if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
         ASSERT(m_paintInfo.context->displayItemList());
         if (!m_paintInfo.context->displayItemList()->displayItemConstructionIsDisabled())
             m_paintInfo.context->displayItemList()->add(clipDisplayItem.release());
     } else {
         clipDisplayItem->replay(*paintInfo.context);
     }
 
     m_pushedClip = true;
 }
 
@@ skipping 11 matching lines @@
         OwnPtr<EndClipDisplayItem> endClipDisplayItem = EndClipDisplayItem::create(m_box, endType);
         ASSERT(m_paintInfo.context->displayItemList());
         m_paintInfo.context->displayItemList()->add(endClipDisplayItem.release());
     } else {
         EndClipDisplayItem endClipDisplayItem(m_box, endType);
         endClipDisplayItem.replay(*m_paintInfo.context);
     }
 }
 
 } // namespace blink